Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Appointment schedule" notion instead of only "Appointments" for a better UX #6371

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

Jerome-Herbinet
Copy link
Member

@Jerome-Herbinet Jerome-Herbinet commented Sep 25, 2024

"Appointment" notion is no clear and creates confusion because this feature don't directly create an appointment but create an "appointment request form". I propose a new notion : "Appointment request form".
I made some wording change test with my browser dev tools. Please check below (real tests from reviewers are welcome) :

Capture d’écran du 2024-09-25 11-40-30
Capture d’écran du 2024-09-25 11-41-37
Capture d’écran du 2024-09-25 11-48-00
Capture d’écran du 2024-09-25 11-51-43
Capture d’écran du 2024-09-25 11-52-29

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 23.54%. Comparing base (cc04b57) to head (2a87755).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
src/components/AppointmentConfigModal.vue 0.00% 1 Missing ⚠️
...components/AppointmentConfigModal/Confirmation.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6371   +/-   ##
=========================================
  Coverage     23.54%   23.54%           
  Complexity      454      454           
=========================================
  Files           247      247           
  Lines         11700    11700           
  Branches       2202     2202           
=========================================
  Hits           2755     2755           
  Misses         8625     8625           
  Partials        320      320           
Flag Coverage Δ
javascript 15.07% <0.00%> (ø)
php 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jerome-Herbinet Jerome-Herbinet force-pushed the Jerome-Herbinet-appointment-request-form-notion branch from 56ec6ed to 9b725f4 Compare September 25, 2024 09:54
@Jerome-Herbinet Jerome-Herbinet marked this pull request as ready for review September 25, 2024 10:00
@Jerome-Herbinet Jerome-Herbinet added 3. to review Waiting for reviews design Related to design, interface, interaction design, UX, etc. enhancement New feature request skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills papercut Annoying recurring issue with possibly simple fix. Feature: Appointments labels Sep 25, 2024
@Jerome-Herbinet Jerome-Herbinet changed the title Update AppointmentConfigList.vue "Appointments request form" notion instead of only "Appointments" for a better UX Sep 25, 2024
@Jerome-Herbinet Jerome-Herbinet changed the title "Appointments request form" notion instead of only "Appointments" for a better UX "Appointment request form" notion instead of only "Appointments" for a better UX Sep 25, 2024
Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exact issue came up in a design review call! :) The discussion led to the conclusion that "Appointment schedule" is more appropriate. This is also on parity with Google Calendar (with uses the wording "Appointment schedule" to set this up) and Calendly (which calls itself an "Appointment scheduling software"). What do you think?

@Jerome-Herbinet
Copy link
Member Author

Appointment schedule

This exact issue came up in a design review call! :) The discussion led to the conclusion that "Appointment schedule" is more appropriate. This is also on parity with Google Calendar (with uses the wording "Appointment schedule" to set this up) and Calendly (which calls itself an "Appointment scheduling software"). What do you think?

Thanks for your reply @nimishavijay ! Despite "Appointment request form" remains my favorite wording (personal preference), your suggestion is of course the best one because it fits wordings used by Google and it will make UX transition easier for end users. So, I'll make some new commits.

@Jerome-Herbinet Jerome-Herbinet force-pushed the Jerome-Herbinet-appointment-request-form-notion branch from b655bbd to c0a4d4c Compare September 25, 2024 11:48
@Jerome-Herbinet Jerome-Herbinet changed the title "Appointment request form" notion instead of only "Appointments" for a better UX "Appointment schedule" notion instead of only "Appointments" for a better UX Sep 25, 2024
@Jerome-Herbinet
Copy link
Member Author

Jerome-Herbinet commented Sep 25, 2024

@nimishavijay changes are done ; can you check and test it ?

Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Only a small change that I didn't notice before: "Appointment schedules" (plural form)

Signed-off-by: Jérôme Herbinet <[email protected]>

"Appointment schedule", juste like G*****

Signed-off-by: Jérôme Herbinet <[email protected]>

"Appointment request form" notion

Signed-off-by: Jérôme Herbinet <[email protected]>

Update AppointmentConfigList.vue

Signed-off-by: Jérôme Herbinet <[email protected]>

Update AppointmentConfigModal.vue

Signed-off-by: Jérôme Herbinet <[email protected]>

"Appointment schedule" (and "Create new"), like Google

Signed-off-by: Jérôme Herbinet <[email protected]>

"Appointment schedule", like Google

Signed-off-by: Jérôme Herbinet <[email protected]>
@Jerome-Herbinet Jerome-Herbinet force-pushed the Jerome-Herbinet-appointment-request-form-notion branch from 1793de2 to 2a87755 Compare September 25, 2024 12:28
@Jerome-Herbinet
Copy link
Member Author

Nice! Only a small change that I didn't notice before: "Appointment schedules" (plural form)

Done @nimishavijay

@st3iny st3iny added this to the v5.1.0 milestone Sep 25, 2024
@st3iny st3iny merged commit 280468e into main Sep 25, 2024
34 of 35 checks passed
@st3iny st3iny deleted the Jerome-Herbinet-appointment-request-form-notion branch September 25, 2024 16:13
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Related to design, interface, interaction design, UX, etc. enhancement New feature request Feature: Appointments feedback-requested papercut Annoying recurring issue with possibly simple fix. skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants